feat(fsm): add support to announce Windows processes. #833
+461
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSVarsha
approved these changes
Jan 13, 2026
CagriYonca
reviewed
Jan 13, 2026
This reverts commit d53fdd8. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Unit tests for TheMachine cmdline-related methods in fsm.py. This test module provides comprehensive coverage for the command line retrieval functions that work across different platforms (Windows, Linux, Unix). Tested functions: - _get_cmdline_windows(): Retrieves command line on Windows using ctypes - _get_cmdline_linux_proc(): Retrieves command line from /proc/self/cmdline - _get_cmdline_unix_ps(): Retrieves command line using ps command - _get_cmdline_unix(): Dispatches to appropriate Unix method - _get_cmdline(): Main entry point with platform detection and error handling Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
fix_announce_on_windows
branch
from
1379596 to
d368a01
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the commit d53fdd8, by reapplying the commit 1da36f4.
The original commit adds a cross-platform process announcement to Instana Host Agents.
The implementation gracefully handles platform differences, ensuring consistent process information on both Unix and Windows environments:
_get_cmdline()function to return the command line of the current monitored process independently of the running platform._get_cmdline_windows()function to return the command line on Windows machines._get_cmdline_unix()that returns the command line in Unix machines. It decides how to collect the information by running either the_get_cmdline_linux_proc()or the_get_cmdline_unix_ps().